RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v4]

[lawrence.andrews]

On Thu, 10 Feb 2022 08:47:51 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed RenderingHints.VALUE_TEXT_ANTIALIAS_GASP and fixed the review comments
>
> test/jdk/java/awt/Graphics/TextAAHintsTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2007, 2022 Oracle and/or its affiliates. All rights reserved.
> 
> Suggestion:
> 
>  * Copyright (c) 2007, 2022, Oracle and/or its affiliates. All rights reserved.
> 
> One more comma.

Done

> test/jdk/java/awt/Graphics/TextAAHintsTest.java line 59:
> 
>> 57:     public static final CountDownLatch countDownLatch = new CountDownLatch(1);
>> 58:     private static Frame frame;
>> 59:     public static String failureReason;
> 
> `failureReason` should also be `volatile`.
> 
> All the fields can be `private`. You access them from this class only; nested classes, including the static ones, have access to private members of the surrounding class.

Fixed

> test/jdk/java/awt/Graphics/TextAAHintsTest.java line 199:
> 
>> 197:     }
>> 198: 
>> 199:     public static void readFailedReason() {
> 
> `readFailureReason` or `getFailureReason`?

Fixed the method name to getFailureReason

> test/jdk/java/awt/Graphics/TextAAHintsTest.java line 221:
> 
>> 219: 
>> 220:     public static void main(String[] args) throws InterruptedException, InvocationTargetException {
>> 221:         java.awt.EventQueue.invokeAndWait(TextAAHintsTest::createTestUI);
> 
> I wonder why `EventQueue` uses fully qualified class name instead of being imported as other classes. That's fine, I'm just wondering.

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/7275