Integrated: 8274939: Incorrect size of the pixel storage is used by the robot on macOS
Sergey Bylokhov
serb at openjdk.java.net
Sat Feb 12 22:13:06 UTC 2022
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
> In JDK 9 the native code for the robot class was reworked to get an access to the HiDPI quality screenshots. So we allocate the data storage for the HiDPI quality and then request the best quality from the macOS.
>
> It works fine if the user request the screenshot of some area, since we properly scale this area. Unfortunately it does not work well if the user request only one pixel, in this case we allocate the array of one element and does not multiply the size by the scale, so if the system scale is 2 then the macOS returns the 2x2 pixels, which does not fit properly to the array of one element. This can be checked by the Xcheck:jni option which produce fatal error in this case.
>
> Solution is to allocate the storage of the proper size 1 * scale * 1 * scale
This pull request has now been integrated.
Changeset: eff5dafb
Author: Sergey Bylokhov <serb at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/eff5dafba9f72bd0612357712ffa472ce1c9166a
Stats: 12 lines in 3 files changed: 7 ins; 0 del; 5 mod
8274939: Incorrect size of the pixel storage is used by the robot on macOS
Reviewed-by: aivanov, prr
-------------
PR: https://git.openjdk.java.net/jdk/pull/5864
More information about the client-libs-dev
mailing list