RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v6]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Mon Feb 14 04:51:12 UTC 2022


On Fri, 11 Feb 2022 18:53:11 GMT, Harshitha Onkar <duke at openjdk.java.net> wrote:

>> test/jdk/javax/swing/JTableHeader/8016524/JTHeaderBorderTest.java line 90:
>> 
>>> 88:                 String headerColor = Integer.toHexString(table.getTableHeader().getBackground().getRGB());
>>> 89:                 String pixelColor = tableColor;
>>> 90:                 boolean isBottomLineVisible = false;
>> 
>> To nitpick, I will much rather use Color instead of converting to String as we are trying to check and compare for Color but it's not a dealbreaker.
>
> @prsadhuk  BufferedImage's getRGB() method returns a int value and does not have equivalent method that returns a Color object (at specified coordinates), I was able to change string comparisons to int. Please let me know if this should be okay?

You could have used getBackground() itself to get a Color object but amnot finicky about it, its upto you.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7219



More information about the client-libs-dev mailing list