RFR: 8280861: Robot color picker broken on Linux with scaling above 100% [v3]
Maxim Kartashev
duke at openjdk.java.net
Tue Feb 15 05:28:14 UTC 2022
On Mon, 14 Feb 2022 18:24:15 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>>> Is this scale parameter is simply ignored?
>>
>> Looks like it. I can only find one call site of `get_drawable_data()` (in [Java_sun_awt_X11_XRobotPeer_getRGBPixelsImpl()](https://github.com/openjdk/jdk/blob/8441d51e71e143250b44eea74114a624cf00cc3e/src/java.desktop/unix/native/libawt_xawt/awt/awt_Robot.c#L336)) and the `scale` parameter is always 1. I think I can drop it from the interface if you prefer.
>
> Yes please, this "scale" just make the code complicated w/o reason.
That's done; please, take a look at the updated code.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7425
More information about the client-libs-dev
mailing list