RFR: 8281738: Create a regression test for checking the 'Space' key activation of focused Button [v2]

Manukumar V S mvs at openjdk.java.net
Tue Feb 15 08:53:09 UTC 2022


On Mon, 14 Feb 2022 23:24:23 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed review comments: waitForIdle() added after frame creation and waits until button gains focus
>
> test/jdk/javax/swing/JButton/SpaceKeyActivatesButton.java line 67:
> 
>> 65:                     createUI();
>> 66:                 });
>> 67: 
> 
> I think you should add robot.waitForIdle() after the frame creation, and also wait until the button will get a focus, since the "requestFocusInWindow" might be ignored.

Fixed it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7460



More information about the client-libs-dev mailing list