RFR: 8236907: JTable added to nested panels does not paint last visible row [v2]

Tejesh R duke at openjdk.java.net
Fri Feb 18 12:36:25 UTC 2022


On Fri, 18 Feb 2022 05:00:28 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8236907: JTable added to nested panels does not paint last
>
> test/jdk/javax/swing/JTable/8236907/LastVisibleRow.java line 88:
> 
>> 86:         } finally {
>> 87:             if (frame != null) SwingUtilities.invokeAndWait(() -> frame.dispose());
>> 88:             if (dialog != null) SwingUtilities.invokeAndWait(() -> dialog.dispose());
> 
> I guess this "dialog" variable is not needed

Updated.

> test/jdk/javax/swing/JTable/8236907/LastVisibleRow.java line 131:
> 
>> 129:         centerPane.add(tablePaneContainer, BorderLayout.NORTH);
>> 130:         contentPane.add(centerPane, BorderLayout.CENTER);
>> 131:         frame.setSize(800, 600);
> 
> It will be good to center the frame on the screen by calling setLocationRelativeTo(null) so that in CI testrun is not affected, reduce the frame size also in that case..

Updated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7422



More information about the client-libs-dev mailing list