RFR: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled [v5]

Toshio Nakamura tnakamura at openjdk.java.net
Mon Feb 21 05:12:44 UTC 2022


> Hi,
> 
> Could you review the fix?
> When non-English characters were printed from JTable on MacOS, CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However, CTextPipe seems not support glyph with slot number of composite fonts.
> 
> The slot data mask of GlyphVector is 0xff000000. In my environment, Japanese font was loaded at slot 4, and glyph data is like [0x40003e5]. Then, unexpected glyph was drawn.

Toshio Nakamura has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:

 - Deleting unused line
 - Merge branch 'master' into 8240756
 - Revised according to review comments
 - Merge branch 'master' into 8240756
 - 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
 - revert previous proposal
 - Merge branch 'master' into 8240756
 - 2nd proposal
 - Revert previous change
 - Merge branch 'master' into 8240756
   merge master
 - ... and 1 more: https://git.openjdk.java.net/jdk/compare/5f6cd127...b623a123

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3619/files
  - new: https://git.openjdk.java.net/jdk/pull/3619/files/e5d3a032..b623a123

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3619&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3619&range=03-04

  Stats: 61451 lines in 1836 files changed: 42385 ins; 10591 del; 8475 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3619.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3619/head:pull/3619

PR: https://git.openjdk.java.net/jdk/pull/3619



More information about the client-libs-dev mailing list