RFR: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge [v2]

[Anton Litvinov]

On Fri, 18 Feb 2022 17:11:13 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Anton Litvinov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   The second version of the fix for JDK-8277922
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 5493:
> 
>> 5491:         }
>> 5492: 
>> 5493:         protected class AccessibleBooleanRenderer
> 
> I think this class, `AccessibleBooleanRenderer` as well as `setCellToDoActionOn` method can have the default access. They're inside package-private class `BooleanRenderer`, I see no reason why these should have higher access level.

Agree, higher access level is not needed in the places specified by you. In the second version of the fix your remark is fully addressed.

> test/jdk/javax/accessibility/JTable/JCheckBoxInJTableCannotBeClickedTest.java line 77:
> 
>> 75:             AWTException e) {
>> 76:             throw new RuntimeException(e);
>> 77:         } finally {
> 
> You can declare `main` to throw `Exception` or this specific list of exceptions and drop catch-block: jtreg catches all types of exceptions and it's a failure.

Hi Alexey. I agree in this implementation of the "main" method of the test catching these exceptions is unnecessary. This remark is fully addressed in the second version of the fix.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7416