Withdrawn: 6742362: JComponent.setFont() font comparison is not correct

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Fri Feb 25 04:16:59 UTC 2022


On Tue, 22 Feb 2022 08:59:52 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Font comparison in JComponent.setFont() uses `font != oldFont` check which is not correct as per Object equality essence. The correct way of checking font equality is to use "equals" as is done in [GlyphLayout](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/font/GlyphLayout.java#L144) , [StandardGlyphVector](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/font/StandardGlyphVector.java#L657) etc
> 
> Existing jtreg, jck test are green.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7571



More information about the client-libs-dev mailing list