RFR: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding [v5]

DamonGuy duke at openjdk.java.net
Mon Feb 28 18:11:06 UTC 2022


On Fri, 25 Feb 2022 21:48:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> DamonGuy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changed robot autodelay time and added wait after creating gui. Added try finally block for frame disposal.
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java line 313:
> 
>> 311:             // use zero insets for view since layout only handles text calculations
>> 312:             text = layoutAndGetText(g, b, aquaBorder, new
>> 313:                     Insets(0,0,0,0), viewRect, iconRect, textRect);
> 
> Please do not break object instantiation: always keep `new` and class name on the same line.

Fixed alongside the other requested changes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7310



More information about the client-libs-dev mailing list