RFR: 4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate [v2]

Phil Race prr at openjdk.java.net
Wed Jan 5 19:11:07 UTC 2022


On Wed, 5 Jan 2022 03:43:53 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>    4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate
>
> test/jdk/javax/print/attribute/StreamServiceSheetCollateTest.java line 52:
> 
>> 50:         OutputStream out = new ByteArrayOutputStream();
>> 51:         StreamPrintService sps = fact[0].getPrintService(out);
>> 52:         if (!sps.isAttributeCategorySupported(SheetCollate.class)) {
> 
> Can we add other attributes to the tests? I made a quick check for some attributes and it looks like the code is quite confused, on my windows, the same issue exists for the "OrientationRequested.class".

I've also fixed OrientationRequested and added other Enum attributes to the test.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6963



More information about the client-libs-dev mailing list