RFR: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled [v4]
Toshio Nakamura
tnakamura at openjdk.java.net
Thu Jan 6 02:49:17 UTC 2022
> Hi,
>
> Could you review the fix?
> When non-English characters were printed from JTable on MacOS, CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However, CTextPipe seems not support glyph with slot number of composite fonts.
>
> The slot data mask of GlyphVector is 0xff000000. In my environment, Japanese font was loaded at slot 4, and glyph data is like [0x40003e5]. Then, unexpected glyph was drawn.
Toshio Nakamura has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
- Revised according to review comments
- Merge branch 'master' into 8240756
- 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
- revert previous proposal
- Merge branch 'master' into 8240756
- 2nd proposal
- Revert previous change
- Merge branch 'master' into 8240756
merge master
- 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3619/files
- new: https://git.openjdk.java.net/jdk/pull/3619/files/c52a9f98..e5d3a032
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3619&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3619&range=02-03
Stats: 973589 lines in 3327 files changed: 514106 ins; 439563 del; 19920 mod
Patch: https://git.openjdk.java.net/jdk/pull/3619.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3619/head:pull/3619
PR: https://git.openjdk.java.net/jdk/pull/3619
More information about the client-libs-dev
mailing list