RFR: 4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate [v3]
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Thu Jan 6 06:23:15 UTC 2022
On Wed, 5 Jan 2022 20:21:07 GMT, Phil Race <prr at openjdk.org> wrote:
>> This fixes a longstanding consistency issue where the Postscript StreamPrintService would report SheetCollate.UNCOLLATED in a list of supported values then report it was not supported under the same conditions.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>
> 4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate
src/java.desktop/share/classes/sun/print/PSStreamPrintService.java line 453:
> 451: !(flavor.equals(DocFlavor.SERVICE_FORMATTED.PAGEABLE) ||
> 452: flavor.equals(DocFlavor.SERVICE_FORMATTED.PRINTABLE))) {
> 453: return attr == SheetCollate.UNCOLLATED;
Shouldn't we need to do the same for SheetCollate in WIn32PrintService#isATtributeValueSupported() where it always return false?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6963
More information about the client-libs-dev
mailing list