RFR: JDK-8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15 [v2]
Matthias Baesken
mbaesken at openjdk.java.net
Tue Jan 11 08:35:58 UTC 2022
> Hello, please review this adjustment for recent SUSE Linux 15.
> The font coding on UNIX, see setOsNameAndVersion in files
>
> src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java
> src/java.desktop/unix/classes/sun/font/MFontConfiguration.java
>
> uses the file /etc/SuSE-release to detect SUSE Linux. However on SUSE Linux 15 this file does not exist any more.
> Instead /etc/os-release can be used as a replacement on SLES12 and SLES15 :
>
> Example content of /etc/os-release
> NAME="SLES"
> VERSION="12-SP2"
> VERSION_ID="12.2"
> PRETTY_NAME="SUSE Linux Enterprise Server 12 SP2"
>
> There the name and version information is stored (NAME=... , VERSION_ID=...).
>
> Additionally I noticed that there is some code duplication in FcFontConfiguration.java and MFontConfiguration.java , what do you think about moving this to some common place ?
>
> Thanks, Matthias
Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
suggestions by mdoerr
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6956/files
- new: https://git.openjdk.java.net/jdk/pull/6956/files/b7822bd7..45e2fad2
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6956&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6956&range=00-01
Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
Patch: https://git.openjdk.java.net/jdk/pull/6956.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/6956/head:pull/6956
PR: https://git.openjdk.java.net/jdk/pull/6956
More information about the client-libs-dev
mailing list