RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v12]

[Alexey Ivanov]

On Mon, 10 Jan 2022 16:59:28 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Adjusted the AquaLF scrollbar to account for border inset settings when dragging the thumb and clicking on the track.
>
> Alisen Chung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
> 
>  - Merge branch 'master' of github.com:alisenchung/jdk into 8190264
>  - updated test
>  - added check for other L&Fs, added newline to test
>  - removed todo comment
>  - finished test
>  - fixed test 2
>  - fixed test
>  - need to fix comparison of BufferedImages
>  - removed robot mouse moves, use pixel colors to check
>  - removed manual tag
>  - ... and 6 more: https://git.openjdk.java.net/jdk/compare/f166bd7b...ee57b8ac

Please update the copyright year in both files to include 2022.

I suggest expanding all the wildcard imports for AquaScrollBarUI.java, which is usually done.

And most importantly: the new code handle horizontal insets. What about the *vertical insets?* It looks a vertical scroll bar has the same issue if there's vertical border.

test/jdk/java/awt/Scrollbar/AquaLFScrollbarTest/ScrollBarBorderTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.

Probably, the copyright year should now contain 2022 too:
Suggestion:

 * Copyright (c) 2021, 2022, Oracle and/or its affiliates. All rights reserved.

-------------

Changes requested by aivanov (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6374