RFR: 8279861: Clarify 'rect' parameters and description of paintTabBorder method in BasicTabbedPaneUI
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Thu Jan 20 05:20:49 UTC 2022
On Tue, 11 Jan 2022 15:50:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
> The protected methods `paintTab` and `paintFocusIndicator` accept the `rect` parameter which is documented as _“rectangles”_. I suggest updating this description to a more descriptive: _“the tab rectangles”_ as the array contains the coordinates of the tabs.
>
> Similarly, the documentation for `assureRectsCreated` method could be updated to clarify which rectangles are created.
>
> The documentation for `paintTabBorder` is inconsistent with other paint methods, it has no ending punctuation. I updated it to be consistent.
>
> I split out these changes from [JDK-8279798](https://bugs.openjdk.java.net/browse/JDK-8279798) and #7031 because this issue will likely require a CSR.
Marked as reviewed by psadhukhan (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/7033
More information about the client-libs-dev
mailing list