Integrated: 8278472: Invalid value set to CANDIDATEFORM structure

Alexey Ivanov aivanov at openjdk.java.net
Thu Jan 20 20:15:50 UTC 2022


On Wed, 19 Jan 2022 20:14:34 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> According to the Windows API reference, `dwStyle` of [`CANDIDATEFORM`](https://docs.microsoft.com/en-us/windows/win32/api/imm/ns-imm-candidateform) structure should be set to `CFS_CANDIDATEPOS` or `CFS_EXCLUDE`. So, `CFS_POINT` is wrong here.
> 
> There are two instances in `AwtComponent::SetCandidateWindow` in [`awt_Component.cpp`](https://github.com/openjdk/jdk/blob/f90425a1cbbc686045c87086af586e62f05f6c49/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp#L3914) where the incorrect value is used.
> 
> Initially, I created this PR for jdk18. [It was suggested](https://github.com/openjdk/jdk18/pull/54#issuecomment-1006432326) to place this fix into the mainline, so this a continuation to [jdk18/pull/54](https://github.com/openjdk/jdk18/pull/54).

This pull request has now been integrated.

Changeset: 2426d58e
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/2426d58e592c54de64ebe0f06448d239aeced082
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

8278472: Invalid value set to CANDIDATEFORM structure

Reviewed-by: prr, naoto, serb

-------------

PR: https://git.openjdk.java.net/jdk/pull/7146



More information about the client-libs-dev mailing list