RFR: 8282526: Default icon is not painted properly [v4]

[Alexey Ivanov]

On Thu, 9 Jun 2022 10:37:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > I am not going trough all the experiments with the SHDefExtractIcon again - at least not in this pull request.
> 
> I absolutely agree, not in this pull request.
> 
> However, I'm for submitting a bug or two to explore other possibilities.

I submitted a list of issues to record all the comments that were raised here as well as in previous reviews.

1. [JDK-8289705](https://bugs.openjdk.org/browse/JDK-8289705): Handle the case where IExtractIconW::Extract returns S_FALSE
2. [JDK-8289707](https://bugs.openjdk.org/browse/JDK-8289707): Use LookupIconIdFromDirectoryEx to extract only available sizes of icon
3. [JDK-8289708](https://bugs.openjdk.org/browse/JDK-8289708): Extract only the requested icon size
4. [JDK-8289756](https://bugs.openjdk.org/browse/JDK-8289756): Do not always request 16x16 icon
5. [JDK-8289766](https://bugs.openjdk.org/browse/JDK-8289766): Unify the two methods for extracting icons on Windows
6. [JDK-8289767](https://bugs.openjdk.org/browse/JDK-8289767): Handle the case where IExtractIconW::GetIconLocation returns E_PENDING

-------------

PR: https://git.openjdk.org/jdk/pull/7805