RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v3]

Andy Goryachev duke at openjdk.org
Thu Jul 7 14:48:29 UTC 2022


On Thu, 7 Jul 2022 06:44:47 GMT, Abhishek Kumar <duke at openjdk.org> wrote:

>> src/java.desktop/share/classes/sun/swing/FilePane.java line 532:
>> 
>>> 530:                         UIManager.getString("FileChooser.detailsViewActionLabelText", l);
>>> 531: 
>>> 532:         byteString      = UIManager.getString("FileChooser.fileSizeBytes", l);
>> 
>> is the '-' character misaligned or is this a github rendering artifact?
>
> I didn't get you. Can you please specify the line number ?

it's minor.

'=' symbols are misaligned between the lines 532 and 533:
        byteString      = UIManager.getString("FileChooser.fileSizeBytes", l);
        kiloByteString = UIManager.getString("FileChooser.fileSizeKiloBytes", l);

I'd suggest either align, or (better) remove any alignment by using only one space.

-------------

PR: https://git.openjdk.org/jdk/pull/9327



More information about the client-libs-dev mailing list