RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v6]

Phil Race prr at openjdk.org
Thu Jul 7 22:29:47 UTC 2022


On Thu, 7 Jul 2022 21:24:29 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> Please review this simple patch. When running idea on jdk17 with asan I have found this buffer overflow.
>> The code checks the cache for at least one free element, while placing 6 elements to the cache.
>> The fix checks the presence of 6 free elements.
>
> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   oops

LGTM although I'd really (really!) like you to break up those long lines before pushing.

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9368



More information about the client-libs-dev mailing list