RFR: 8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Jul 11 11:38:43 UTC 2022


On Mon, 11 Jul 2022 09:28:22 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> BasicOptionPaneUI.addMessageComponents() uses recursion to split message strings at newlines, generating a StackOverflowError when the message string contains an unusually large number of newlines.
>> Fixed by catching StackOverflow and ignoring so that application is not stuck.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Format

I guess if it's not successive, it will not exercise this condition so it will not recurse as much

if (nl >= 0) {
                // break up newlines
                if (nl == 0) {

-------------

PR: https://git.openjdk.org/jdk/pull/9388



More information about the client-libs-dev mailing list