RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

[Damon Nguyen]

On Tue, 12 Jul 2022 19:49:49 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Updated method names for PassFailJFrame
>>  - Merge branch 'openjdk:master' into 8054572/JComboBoxBorderAlignmentFix
>>  - Removed commented lines. Added newlines.
>>  - Updated test with PassFailJFrame
>>  - Added test
>>  - Adjusted height and coordinate for editable JComboBox
>
> test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java line 59:
> 
>> 57: //
>> 58: //            }
>> 59: 
> 
> Might have missed removing commented lines

Thanks for catching that. I also added a few newlines for long lines of code. I think I forgot to save my latest changes.

> test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java line 84:
> 
>> 82:             PassFailJFrame.positionTestFrame(frame,
>> 83:                     PassFailJFrame.Position.HORIZONTAL);
>> 84:         });
> 
> These methods need to be changed to `addTestWindow `and `positionTestWindow` based on the recently integrated changes to PassFailJFrame. 
> https://github.com/openjdk/jdk/blob/d9ca438d06166f153d11bb55c9ec672fc63c0e9e/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L294

I remember this conversation. I synced my local branch and updated the methods. Tested and the test still works.

-------------

PR: https://git.openjdk.org/jdk/pull/9473