RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Wed Jul 13 07:04:49 UTC 2022


On Wed, 13 Jul 2022 06:01:39 GMT, Abhishek Kumar <duke at openjdk.org> wrote:

>> src/java.desktop/share/classes/sun/swing/FilePane.java line 1203:
>> 
>>> 1201:                     }
>>> 1202:                 } else if (len < 1024L) {
>>> 1203:                     text = MessageFormat.format(byteString, len);
>> 
>> For len < 1024 say 433, does it now show 433 bytes or 433 B? 
>> Since in resource file, you are using {0} B and not {0} bytes..I guess in ubuntu native, it shows 433 bytes and not 433 B..
>
> It will show 433 B now, in ubuntu native it shows 433 bytes. 
> bytes replaced by B to handle plural forms, otherwise for 1 byte file it show 1 bytes.

i guess it's not right then, no? if you are changing to mimic native, then it should be "bytes" and not "B". Just for 1 byte case, you cannot compromise on other file size(s), in my opinion.

-------------

PR: https://git.openjdk.org/jdk/pull/9327



More information about the client-libs-dev mailing list