RFR: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines [v3]

[Phil Race]

On Wed, 29 Jun 2022 06:53:29 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS machines, especially in MacOSX 12 machines. It seems to be a testbug as adding some stability improvements fix the issue. It intermittently fails in CI causing some noise. This test was already problem listed in windows due to an umbrella bug JDK-8238720. I have removed the problem listing and tested it in windows platform also, it works fine there.
>> 
>> Fix:
>> Some stability improvements have been done and the test has been run 100 times per platform in mach5 and got full PASS.
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed: Reverted variable name change, reverted +20 in point

Changes requested by prr (Reviewer).

test/jdk/ProblemList.txt line 453:

> 451: java/awt/event/KeyEvent/DeadKey/deadKeyMacOSX.java 8233568 macosx-all
> 452: java/awt/TrayIcon/RightClickWhenBalloonDisplayed/RightClickWhenBalloonDisplayed.java 8238720 windows-all
> 453: java/awt/PopupMenu/PopupMenuLocation.java 8238720 windows-all

8238720 is about failing when run on hi-dpi on windows. I don't see anything you've done to fix that

test/jdk/java/awt/PopupMenu/PopupMenuLocation.java line 130:

> 128:         robot.waitForIdle();
> 129:         if (!actionEventReceivedLatch.await(5, TimeUnit.SECONDS)) {
> 130:             captureScreen();

So if it hasn't passed in 5 seconds, you fail the test. How is that improving stability ?

-------------

PR: https://git.openjdk.org/jdk/pull/9187