RFR: 6391806: JLabel and AbstractButton's imageUpdate method should be better specified [v6]
Phil Race
prr at openjdk.org
Fri Jul 15 22:16:03 UTC 2022
On Wed, 13 Jul 2022 07:25:32 GMT, Abhishek Kumar <duke at openjdk.org> wrote:
>> JLabel and AbstractButton's imageUpdate method description updated.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> JLabel and AbstractButton imageUpdate method description modified
src/java.desktop/share/classes/javax/swing/AbstractButton.java line 2150:
> 2148: /**
> 2149: * If the button icon for present button state is either <code>null</code>
> 2150: * or not an <code>ImageIcon</code> with an <code>Image</code> equal to the
assuming the intent is correct, "for the current button state" reads better than "for present button state"
src/java.desktop/share/classes/javax/swing/AbstractButton.java line 2152:
> 2150: * or not an <code>ImageIcon</code> with an <code>Image</code> equal to the
> 2151: * passed in <code>Image</code>, return <code>false</code>; Otherwise it
> 2152: * will delegate to the super-class.
"; Otherwise"
That isn't a new sentence so you should not capitalise.
-------------
PR: https://git.openjdk.org/jdk/pull/9240
More information about the client-libs-dev
mailing list