RFR: 7132413: [macosx] closed/javax/swing/AbstractButton/5049549/bug5049549.java fails on MacOS [v2]

Sergey Bylokhov serb at openjdk.org
Sun Jul 17 03:07:06 UTC 2022


On Fri, 15 Jul 2022 04:57:19 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> It was seen that some of the icons like disabled-selected:,  rollover icons are not shown.
>> Fixed to get the default selected icon and use that if in case the icon for that state is not set.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add test

src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java line 403:

> 401:         if (icon == null) return;
> 402: 
> 403:         Icon selectedIcon = null;

It looks like a similar pattern is used in the AquaButtonLabeledUI.paintIcon(), can we align the logic of both methods?

-------------

PR: https://git.openjdk.org/jdk/pull/9481



More information about the client-libs-dev mailing list