RFR: 8264999: GeneralPath.lineTo() to itself produces jagged lines [v4]

Phil Race prr at openjdk.org
Mon Jul 18 00:17:04 UTC 2022


On Fri, 10 Jun 2022 01:24:48 GMT, Jeremy <duke at openjdk.org> wrote:

>> Previously when you drew a line that moved exactly (+0, +0) with a miter stroke the Stroker class acted like a horizontal miter was appropriate. Now we abort instead, so no miter is applied.
>> 
>> The new unit test tests the original steps plus several variations.
>> 
>> I'm a little nervous about this change because it looks like someone previously considered this exact condition and implemented a different behavior. I don't think I understand the original rationale.
>
> Jeremy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8264999: GeneralPath.lineTo() to itself produces jagged lines
>   
>   Revising failing (commented out) scenarios.

Testing looks good.

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.org/jdk/pull/8943



More information about the client-libs-dev mailing list