RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v6]

Andy Goryachev duke at openjdk.org
Mon Jul 18 20:01:13 UTC 2022


On Mon, 18 Jul 2022 19:50:28 GMT, Phil Race <prr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   properties file reverted back and filesize shown in KB
>
> src/java.desktop/share/classes/sun/swing/FilePane.java line 1207:
> 
>> 1205:                     len /= 1024L;
>> 1206:                     if (len < 1024L) {
>> 1207:                         text = MessageFormat.format(kiloByteString, len);
> 
> So ALL of these have an "off by one" issue don't they ?
> 
> Here a file that is (for example) 2047 bytes in size will be displayed as "1KB"

I think this also deserves extracting it into a separate function, and a unit test.
And perhaps another unit test with a non-English locale.

-------------

PR: https://git.openjdk.org/jdk/pull/9327



More information about the client-libs-dev mailing list