RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v3]

Harshitha Onkar honkar at openjdk.org
Thu Jul 21 00:27:07 UTC 2022


On Wed, 20 Jul 2022 00:09:05 GMT, Phil Race <prr at openjdk.org> wrote:

>> @prrace Thank you for reviewing. I do see your point - when taskbars and menu bars are located on top or left side of the screen, they would overlap the test instruction frame.  
>> 
>> Two possible solutions:
>> 
>> 1. Going with a fixed amount of offset on where to position the top-left corner of the instruction frame window. Probably this would not be ideal considering different screen settings and platforms.
>> 
>> 2. The other approach would be to use [GraphicsEnvironment.getMaximumWindowBounds()](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/awt/GraphicsEnvironment.html#getMaximumWindowBounds()) to get the displayable window size and position the instruction frame accordingly ?
>
> More than that - this code needs to call setlocation, and do "whatever" to make sure that is actually pushed to the "window manager" and the REAL location of the window come back. The way the code is written it sets a couple of vars and then reads back its own values .. no chance of finding the REAL location

In the recent update the following points are addressed:

- Screen insets are used to account of taskbar position and the placement of the instruction frame at top-left corner
- Position option description update

Changes regarding pushing the latest position to window manager are being evaluated.

-------------

PR: https://git.openjdk.org/jdk/pull/9525



More information about the client-libs-dev mailing list