RFR: 4797982: Setting negative size of JSplitPane divider leads to unexpected results. [v2]
Phil Race
prr at openjdk.org
Mon Jul 25 21:34:44 UTC 2022
On Mon, 25 Jul 2022 09:48:16 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Setting JSplitPane divider size to negative value leads to unexpected results and is not desirable and seems to be not practical.
>> I guess we should return IAE but it might break existing app so fixed to clamp it to 0 incase negative value is tried to be set for divider size.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix to return L&F specific divider size
>>we need a CSR
> Canyou please clarify why? Is it because we are changing the behavior?
So instead you propose to change from one un-specified behaviour to another un-specified behaviour ?
It seems to me we should be updating javadoc to say what should happen.
The "just return" sounds good to me .. in javadoc terms that would be "values < 1 are ignored" ..
-------------
PR: https://git.openjdk.org/jdk/pull/9566
More information about the client-libs-dev
mailing list