RFR: 8290278: JavaDoc of index parameter of method JTabbedPane.insertTab

Tejesh R tr at openjdk.org
Tue Jul 26 04:22:48 UTC 2022


On Fri, 22 Jul 2022 19:07:29 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Minor suggestion: how about we add index to the comparison?
> 
> ` {@code (index >= 0 && index <= getTabCount())}` since index adds more clarity to the comparison and additionally to keep it consistent across the JTabbedPane similar to -
> 
> https://github.com/openjdk/jdk/blob/ef8486a1a40c8b65d3db6048c3dc79802073148d/src/java.desktop/share/classes/javax/swing/JTabbedPane.java#L1089
> 
> https://github.com/openjdk/jdk/blob/ef8486a1a40c8b65d3db6048c3dc79802073148d/src/java.desktop/share/classes/javax/swing/JTabbedPane.java#L1264

Yeah @honkar-jdk , thank you for noticing it, will update it accordingly.

-------------

PR: https://git.openjdk.org/jdk/pull/9496



More information about the client-libs-dev mailing list