RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v7]

Andy Goryachev angorya at openjdk.org
Wed Jul 27 15:26:52 UTC 2022


On Thu, 21 Jul 2022 06:44:26 GMT, Abhishek Kumar <duke at openjdk.org> wrote:

>> JDK does not do unit tests in this way. There is no place to put it.
>> We do functional "system" level regression tests.
>
> I guess extracting this code to a function won't give much advantage as it is not called from multiple places.

I do not understand how it is possible to develop without unit tests.  

I would test this function with 0, 1, and (N-1, N, N+1) where N is in range of
1000, 1024, 1_000_000, 1024*1024, 1_000_000_000, 1024^3, 1_000_000_000_000, 1024^4.
(I doubt you can create 1TB test file)

-------------

PR: https://git.openjdk.org/jdk/pull/9327



More information about the client-libs-dev mailing list