RFR: 8290278: JavaDoc of index parameter of method JTabbedPane.insertTab [v2]

Phil Race prr at openjdk.org
Wed Jul 27 19:16:52 UTC 2022


On Tue, 26 Jul 2022 05:10:37 GMT, Tejesh R <tr at openjdk.org> wrote:

>> JavaDoc of _JTabbedPane.inseetTab()_ is updated. The index position to insert a new tab ranges from 0 to _TabCount_(Position after the last tab position), the same is updated from _> 0_ to _>= 0_ .
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated as per Review Comments

src/java.desktop/share/classes/javax/swing/JTabbedPane.java line 726:

> 724:      * @param index the position to insert this new tab
> 725:      *       {@code (index >= 0 && index <= tab count)}
> 726:      *

Now you've made it more like code, except for less like code by changing getTabCount() to tab count.

I suggest
* @param index the position to insert this new tab
* where {@code (index >= 0 && index <= getTabCount())}

-------------

PR: https://git.openjdk.org/jdk/pull/9496



More information about the client-libs-dev mailing list