RFR: 6521141: DebugGraphics NPE @ setFont();

Tejesh R tr at openjdk.org
Thu Jul 28 14:42:47 UTC 2022


On Thu, 28 Jul 2022 12:49:59 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> `DebugGraphics` class has a Graphics instance which is been used in slowed down drawing. The `graphics` object is not initialized anywhere inside the class, where it is expected to set explicitly by the user. When the user doesn't set it and try to use the any mehtods like `drawing/setFont`, NPE is raised which is expected. The scenario is taken care by checking if the `graphics` object is null before using it inside the class, thus eliminating the NPE case.
>
> src/java.desktop/share/classes/javax/swing/DebugGraphics.java line 349:
> 
>> 347:             info().log(toShortString() +
>> 348:                     " Setting clipRect: " + (new Rectangle(x, y, width, height)) +
>> 349:                     " New clipRect: " + graphics.getClip());
> 
> Why this line change is needed? Probably you have added some tabs..Remove this change and similarly from other logs down below.

I think auto indentation has caused this, will undo these tabs changes.

-------------

PR: https://git.openjdk.org/jdk/pull/9673



More information about the client-libs-dev mailing list