RFR: 8259687: JTabbedPane.setComponentAt doesn't hide previously visible tab component [v2]
Harshitha Onkar
honkar at openjdk.org
Sat Jul 30 00:29:54 UTC 2022
On Fri, 29 Jul 2022 11:35:45 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> bug id changed, added isVisible check
>
> src/java.desktop/share/classes/javax/swing/JTabbedPane.java line 1603:
>
>> 1601: if (this.visComp != null &&
>> 1602: !this.visComp.equals(component)) {
>> 1603: // previous component visibility is set to false
>
> It seems `isVisible` is checked before changing the visibility..Should we do it here too?
I thought it might be redundant since the setVisible() checks for visibility of component within show() and hide(). But to add clarity I have add `isVisible` check.
> test/jdk/javax/swing/JTabbedPane/TabbedPaneBug.java line 35:
>
>> 33: /*
>> 34: * @test
>> 35: * @bug 8265586
>
> bugid wrong
Updated
-------------
PR: https://git.openjdk.org/jdk/pull/9681
More information about the client-libs-dev
mailing list