RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v4]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Thu Jun 2 05:05:25 UTC 2022


On Thu, 2 Jun 2022 04:48:09 GMT, Tejesh R <tr at openjdk.org> wrote:

> > > > > Shall the test be located in `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
> > > > > Usually, there's been a folder with bugid (`/4380543/`) for each test. Do we use the flat layout now?
> > > > 
> > > > 
> > > > @aivanov-jdk Recently we have started to use the latter and remove the extra folder (`/4380543/`)
> > > 
> > > 
> > > Thank you for clarification, Harshitha.
> > 
> > 
> > Yes, blame (?) me :-) We may not always remember to point it out but it is what we want. I've never seen the point in an extra level of folder except when the test is composed of multiple files all unique to the test. I also request that new tests not be given names like bug87654321.java but instead be named in a way that you can tell what they are supposed to be testing like in this case something like RadioButtonMarginTest.java
> 
> Sure @prrace , will rename the test. Harshitha also suggested that previously, I thought of retaining for this test.

But it's not a new test. I guess you are moving it from closed to open, right? 
and recent PRs prefer keeping the same name to view the history of the test..
I dont object to it but we should be consistent..

-------------

PR: https://git.openjdk.java.net/jdk/pull/8721



More information about the client-libs-dev mailing list