RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v3]

Tejesh R tr at openjdk.java.net
Thu Jun 2 05:29:32 UTC 2022


On Wed, 1 Jun 2022 17:09:37 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > > > I wonder why the test is Windows-specific if it allows changing Look and Feels.
> > > > The only Look and Feel which ignores the background is Nimbus, other L&Fs on Windows at least paint the yellow and green background. As such, the test can be run on other platforms.
> > > > Was the original bug in Windows Look and Feel? If so, you may want to make it the default L&F.
> > > > The instructions don't mention anything about other Look and Feels. Does the tester have to verify each presented L&F?
> > > 
> > > 
> > > I think the test was in windows which I might have retained the os type, will check and confirm once. The tester have to verify with each L&F for left margin check.
> > 
> > 
> > Yeah, it was only for Motif and Windows before, so I have retained it for only windows os.
> 
> I can see no reason why the test is for Windows only.
> 
> The original bug [JDK-4380543](https://bugs.openjdk.java.net/browse/JDK-4380543) lists all the operating systems as affected. Then [JDK-8134640](https://bugs.openjdk.java.net/browse/JDK-8134640) asked to support all Look-and-Feels, which somewhat implies other platforms should also be tested.

Ok. Since this PR is about the movement of test from closed to open, I would like to retain it for Windows alone @aivanov-jdk as the bug fix [JDK-8134640](https://bugs.openjdk.java.net/browse/JDK-8134640) has been taken care for windows. Will surely plan for other L&F in sometime.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8721



More information about the client-libs-dev mailing list