RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v3]
Tejesh R
tr at openjdk.java.net
Thu Jun 2 09:41:37 UTC 2022
On Thu, 2 Jun 2022 07:51:00 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
> > > I can see no reason why the test is for Windows only.
> > > The original bug [JDK-4380543](https://bugs.openjdk.java.net/browse/JDK-4380543) lists all the operating systems as affected. Then [JDK-8134640](https://bugs.openjdk.java.net/browse/JDK-8134640) asked to support all Look-and-Feels, which somewhat implies other platforms should also be tested.
> >
> >
> > Ok. Since this PR is about the movement of test from closed to open, I would like to retain it for Windows alone @aivanov-jdk as the bug fix [JDK-8134640](https://bugs.openjdk.java.net/browse/JDK-8134640) has been taken care for windows. Will surely plan for other L&F in sometime.
>
> Why can't we make it run on other platforms here?
>
> All it takes is removing `@requires (os.family == "windows")`. Well, obviously, you have to run it on macOS and Linux to make sure it works as expected.
>
> I think doing it right now is more than reasonable compared to submitting a new issue just to remove the OS restriction and going through the code review.
Sorry, had really misunderstood what you had meant, removing os specific is a great idea. Thank you @aivanov-jdk .
-------------
PR: https://git.openjdk.java.net/jdk/pull/8721
More information about the client-libs-dev
mailing list