RFR: 8282526: Default icon is not painted properly [v4]

[Alexander Zuev]

On Wed, 1 Jun 2022 23:44:23 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Do we need to update the size value and take into account the low/hi sizes?

Not exactly, the issue is that for some files (but just for some of them) this call ignores the  high icon size parameter and always returns the set of small and large icons as 16x16 plus 32x32. For the rest of the files it returns 16x16 and the requested size. If low size is not set it is assumed to be 16x16 so we can omit setting it.

> Does it mean that we will extract all images except on the sides twice? for 16x16 we will extract 16x16 and 32x32 on the next iteration for 32x32 we will extract 32x32 and 64x64?

No, on the next iteration we will extract 16x16 and 64x64. So on each iteration we are going to extract additionally 16x16 icon and if size is 24 or more than we will ignore it. Since all the icons requested are cached that will not cause any performance degradation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7805