RFR: 8012675: Javadoc for javax.swing.text.html.parser.Parser.handleComment() needs to be updated [v4]

Damon Nguyen dnguyen at openjdk.java.net
Mon Jun 6 20:45:47 UTC 2022


On Wed, 1 Jun 2022 18:32:09 GMT, Phil Race <prr at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed print statements.
>
> src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java line 1123:
> 
>> 1121:          */
>> 1122:         public void handleComment(char[] data, int pos) {
>> 1123:             System.out.println("HTMLEditorKit");
> 
> And this one ?

Fixed. Had some branching issues that I recently resolved. I lost track of when this was committed and had to revert back to an older commit to see this change.

> src/java.desktop/share/classes/javax/swing/text/html/parser/DocumentParser.java line 34:
> 
>> 32: import javax.swing.text.SimpleAttributeSet;
>> 33: import javax.swing.text.html.HTML;
>> 34: import javax.swing.text.html.HTMLEditorKit;
> 
> Then there's these changes. OK .. too much .. let's just revert all the files that are import only changes.

Reverted all import changes.

> test/jdk/javax/swing/text/html/parser/HtmlTagParserTest.java line 1:
> 
>> 1: import java.awt.Dimension;
> 
> where's the GPL header on this test ?

Added the header and moved the test to the HTML folder instead since I believe the process involves classes beyond just the Parser. For example, I found that the tags and unknown tags are located in the HTML class. I can move it back if it seems more appropriate since the issue requests changes to the Parser's doc only.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7446



More information about the client-libs-dev mailing list