RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v2]

Sergey Bylokhov serb at openjdk.java.net
Mon Jun 6 21:14:28 UTC 2022


On Mon, 6 Jun 2022 15:44:34 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test is failing in iMac CI systems owing to color difference of 1
>> 
>> `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0`
>> 
>> Added minor color tolerance check. CI testing is green
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use RObot.createMultiResoutionCapture

test/jdk/javax/swing/text/CSSBorder/6796710/bug6796710.java line 147:

> 145:         MultiResolutionImage img = robot.createMultiResolutionScreenCapture(rect);
> 146:         return (BufferedImage)img.getResolutionVariant(rect.width, rect.height);
> 147:         //return robot.createScreenCapture(rect);

Isn't the old and new code should get the same result? The old createScreenCapture always creates an image of the low dpi quality. The createMultiResolutionScreenCapture creates two images low/hi dpi, but since you request the same size "rect" the low dpi image is returned, no?

-------------

PR: https://git.openjdk.java.net/jdk/pull/9011



More information about the client-libs-dev mailing list