RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v9]

Alexey Ivanov aivanov at openjdk.java.net
Tue Jun 7 10:50:23 UTC 2022


On Mon, 6 Jun 2022 06:08:38 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated based on review comments

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JRadioButton/bug4380543.java line 58:

> 56:                2. Rendering depends on OS and supported Look and Feels.
> 57:                   Verify only with those L&F where margins are visible.
> 58:                3. If Left inset(margin) appear too small, press Fail,

Suggestion:

               3. If Left inset(margin) appears too small, press Fail,

test/jdk/javax/swing/JRadioButton/bug4380543.java line 72:

> 70:                     //Adding the Test Frame to handle dispose
> 71:                     passFailJFrame.addTestFrame(testObj);
> 72:                     passFailJFrame.positionTestFrame(testObj, PassFailJFrame.Position.HORIZONTAL);

This was correct: you're calling static methods; such methods should not be called _via an instance variable_ but via the class name. Alternatively, you can static-import these methods.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8721



More information about the client-libs-dev mailing list