RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v10]

Alexey Ivanov aivanov at openjdk.java.net
Tue Jun 7 12:31:16 UTC 2022


On Tue, 7 Jun 2022 11:19:10 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated based on review comments

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/JRadioButton/bug4380543.java line 58:

> 56:                2. Rendering depends on OS and supported Look and Feels.
> 57:                   Verify only with those L&F where margins are visible.
> 58:                3. If Left inset(margin) appears too small, press Fail,

Suggestion:

               3. If the Left inset(margin) appears too small, press Fail,

I guess the article is missing here.

It may be missing in the first item too: “…around *the* Radio Button…”

test/jdk/javax/swing/JRadioButton/bug4380543.java line 94:

> 92:         JRadioButton rb  = new JRadioButton("JRadioButton");
> 93:         rb.setMargin(new Insets(20, 20, 20, 20));
> 94:         rb.setBackground(Color.green);

In the new code, we should use uppercase color constants, I guess.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8721



More information about the client-libs-dev mailing list