RFR: 8012675: Javadoc for javax.swing.text.html.parser.Parser.handleComment() needs to be updated [v8]
Damon Nguyen
dnguyen at openjdk.java.net
Wed Jun 8 16:36:34 UTC 2022
On Tue, 7 Jun 2022 18:41:25 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Changed doc text.
>
> test/jdk/javax/swing/text/html/HtmlTagParserTest.java line 83:
>
>> 81: }
>> 82:
>> 83: public static void main(String args[]) throws InterruptedException,
>
> Suggestion:
>
> public static void main(String[] args) throws InterruptedException,
>
>
> Please use Java-style array declaration.
Thanks for catching that. Also, the reasoning for the test originally using a temporary file to create HTML was to have an HTML file that could be opened itself and compared towards. I see that it's not necessary for this test, but was useful at the time. I thought it could still be useful, but this test with the HTML stored in a string is probably sufficient.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7446
More information about the client-libs-dev
mailing list