RFR: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.

Harshitha Onkar honkar at openjdk.java.net
Fri Jun 10 06:05:45 UTC 2022


Due to incorrect AWT Frame inset values being returned from native code, few of the components in the frame were not being shown completely on Windows. With the proposed fix, correct insets are obtained which in turn sizes and displays the frame correctly.

The default insets obtained from the Win system was adding only `::GetSystemMetrics(SM_CXSIZEFRAME)` for **WS_THICKFRAME** and the insets were off by 6px from the expected value. `::GetSystemMetrics(SM_CXPADDEDBORDER)` is additionally added to top, bottom, left and right insets to account for the 6px. [GetSystemMetric() Document](https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getsystemmetrics)

A test case is added which checks if the actual frame size is equal to the expected frame size (frame.getSize() == frame.getPreferredSize()), thus checking if frame.pack() works as expected.

Following are before and after screenshots - 
![image](https://user-images.githubusercontent.com/95945681/172999272-981a0b07-2bd1-425c-b73d-f21f68922262.png)

-------------

Commit messages:
 - removed extra newline
 - AWT frame.pack fix

Changes: https://git.openjdk.org/jdk/pull/9118/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9118&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8265586
  Stats: 120 lines in 2 files changed: 114 ins; 3 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/9118.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9118/head:pull/9118

PR: https://git.openjdk.org/jdk/pull/9118



More information about the client-libs-dev mailing list