RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v4]

[Alexey Ivanov]

On Fri, 10 Jun 2022 12:49:08 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test is failing in iMac CI systems owing to color difference of 1
>> 
>> `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0`
>> 
>> Added minor color tolerance check. CI testing is green
>
> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix review comments
>  - Fix review comments

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/text/CSSBorder/6796710/bug6796710.java line 76:

> 74: 
> 75:     private static JPanel pnBottom;
> 76:     private static final int COLORTOLERANCE = 5;

It's common to separate words in constants by an underscore: `COLOR_TOLERANCE`.

test/jdk/javax/swing/text/CSSBorder/6796710/bug6796710.java line 163:

> 161:                 if ((Math.abs(red1 - red2) > COLORTOLERANCE) ||
> 162:                     (Math.abs(green1 - green2) > COLORTOLERANCE) ||
> 163:                     (Math.abs(blue1 - blue2) > COLORTOLERANCE)) {

Are binary operators usually wrapped to the next line or left on the same line?

Which style is the preferred one?

-------------

PR: https://git.openjdk.org/jdk/pull/9011