RFR: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set. [v2]

Harshitha Onkar honkar at openjdk.java.net
Sat Jun 11 00:33:58 UTC 2022


On Fri, 10 Jun 2022 12:01:21 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed os version check, added review changes
>
> src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 1440:
> 
>> 1438:                     ::GetSystemMetrics(SM_CXDLGFRAME);
>> 1439:                 m_insets.top = m_insets.bottom =
>> 1440:                     ::GetSystemMetrics(SM_CYDLGFRAME);
> 
> It's likely needed here as well.
> 
> Make the frame non-resizeable to get into this block.

Added `SM_CXPADDEDBORDER` to Non-Resizable Frames. After the addition of padded border the second button is being shown similar to Resizable frames. But unlike resizable frames,  for the non-resizable frames - the actual frame size and the preferred size are different. Ideally the frame.getSize() should be equal to preferred size when frame.pack() is used.

-------------

PR: https://git.openjdk.org/jdk/pull/9118



More information about the client-libs-dev mailing list