RFR: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set. [v3]

[Dmitry Markov]

On Mon, 13 Jun 2022 21:24:09 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Due to incorrect AWT Frame inset values being returned from native code, few of the components in the frame were not being shown completely on Windows. With the proposed fix, correct insets are obtained which in turn sizes and displays the frame correctly.
>> 
>> The default insets obtained from the Win system was adding only `::GetSystemMetrics(SM_CXSIZEFRAME)` for **WS_THICKFRAME** and the insets were off by few pixels from the expected value. `::GetSystemMetrics(SM_CXPADDEDBORDER)` is additionally added to top, bottom, left and right insets to account for the 6px. [GetSystemMetric() Document](https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getsystemmetrics)
>> 
>> A test case is added which checks if the actual frame size is equal to the expected frame size (frame.getSize() == frame.getPreferredSize()), thus checking if frame.pack() works as expected.
>> 
>> Following are before and after screenshots - 
>> ![image](https://user-images.githubusercontent.com/95945681/172999272-981a0b07-2bd1-425c-b73d-f21f68922262.png)
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor changes

Marked as reviewed by dmarkov (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/9118