RFR: 8012675: Javadoc for javax.swing.text.html.parser.Parser.handleComment() needs to be updated [v17]

Damon Nguyen dnguyen at openjdk.org
Tue Jun 21 20:02:44 UTC 2022


On Tue, 21 Jun 2022 19:36:17 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I tried to cover this in earlier commits where I differentiate known but unsupported tags, such as script tags, and completely unknown tags. In conversation and testing, HTMLEditorKit.HTMLFactory has a create method that creates HiddenTagViews for unknown tags and for a small list of tags (title, script, param, etc.). In the end, these are all treated the same, so I grouped script tags in this javadoc change. Script tags do have a special case in the Parser where it is handled as a comment but being handled as a comment doesn't change the behavior and still displays the content.
>
> Comments are rendered in a `JTextArea`, that's the only difference. It's covered in the test.
> 
> Adding these details could be overkill.

I thought the same about the additional details being overkill, so I decided to write it the way I did. I could add the details about script tags specifically being handled as a comment, but I believe the current text describes it sufficiently. Let me know what you think.

-------------

PR: https://git.openjdk.org/jdk/pull/7446



More information about the client-libs-dev mailing list