RFR: 8284767: Create an automated test for JDK-4422535 [v4]
Srinivas Mandalika
smandalika at openjdk.org
Wed Jun 22 11:42:06 UTC 2022
> Create an automated test for [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535)
> AccessibleValue implementation only accept Integers
> The AccessibleValue implementations of the following components:
>
> java.awt.Scrollbar
> javax.swing.AbstractButton
> javax.swing.JInternalFrame
> javax.swing.JSplitPane
> javax.swing.JScrollBar
> javax.swing.JProgressBar
> javax.swing.JSlider
>
> require the argument to setCurrentAccessibleValue(Number) to be an Integer, else they completely ignore it - it returns a false indicating that the value has not been set by the return value, but they cannot know the reason for that).
>
> The test verifies that for each of the above components, the AccessibleValue is set when it is set to a Number (Float, Double, long etc) and not just for an Integer.
>
> his review is for migrating tests from a closed test suite to open.
>
> Testing:
> The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64.
Srinivas Mandalika has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
- Merge branch 'openjdk:master' into 8284767
- Review comment fixed: removed redundant headful tag
- Review Comments Fixed: Fixed File location path.
- Review Comments Fixed: Simplified test code with a loop over the JComponents being tested.
- 8284767: Create an automated test for JDK-4422535
- 8284767: Create an automated test for JDK-4422535
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/8220/files
- new: https://git.openjdk.org/jdk/pull/8220/files/4a57e660..258971c7
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=8220&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=8220&range=02-03
Stats: 393040 lines in 5701 files changed: 260846 ins; 98299 del; 33895 mod
Patch: https://git.openjdk.org/jdk/pull/8220.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/8220/head:pull/8220
PR: https://git.openjdk.org/jdk/pull/8220
More information about the client-libs-dev
mailing list